[PATCH] D25048: Tune isHotFunction/isColdFunction

[David Li via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:77
   // convenience method that calls isHotCount.
-  return (FunctionCount &&
-          FunctionCount.getValue() >=
-              (uint64_t)(0.3 * (double)Summary->getMaxFunctionCount()));
+  return FunctionCount && isHotCount(FunctionCount.getValue());
 }
----------------
Can you remove this change and make the first patch NFC?


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:158
+    if (PSI.isFunctionEntryHot(&F))
       OS << " :hot ";
+    else if (PSI.isFunctionEntryCold(&F))
----------------
s/:hot/:hot entry/


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:160
+    else if (PSI.isFunctionEntryCold(&F))
       OS << " :cold ";
     OS << "\n";
----------------
cold entry


https://reviews.llvm.org/D25048