[PATCH] D25048: Tune isHotFunction/isColdFunction

Easwaran Raman via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 13:38:54 PDT 2016


eraman added a comment.

LGTM (after addressing David's comment on separating into two patches)



================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:148
 
-// FIXME: This only tests isHotFunction and isColdFunction and not the
+// FIXME: This only tests isFunctionEntryHot and isFunctionEntryCold and not the
 // isHotCount and isColdCount calls.
----------------
Remove this FIXME since isFunctionEntryHot calls isHotCount.


https://reviews.llvm.org/D25048





More information about the llvm-commits mailing list