[PATCH] D24996: Move UTF functions into namespace llvm.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 17:30:22 PDT 2016


Phab is down, but I looked at the diff and it lgtm. Feel free to commit.

On Tue, Sep 27, 2016 at 6:07 PM, Justin Lebar <jlebar at google.com> wrote:

> jlebar created this revision.
> jlebar added a reviewer: rnk.
> jlebar added a subscriber: llvm-commits.
> Herald added subscribers: mgorny, beanz, klimek.
>
> This lets people link against LLVM and their own version of the UTF
> library.
>
> I determined this only affects llvm, clang, lld, and lldb by running
>
> $ git grep -wl 'UTF[0-9]\+\|\bConvertUTF\bisLegalUTF\|getNumBytesFor' |
> cut -f 1 -d '/' | sort | uniq
>   clang
>   lld
>   lldb
>   llvm
>
> Tested with
>
>   ninja lldb
>   ninja check-clang check-llvm check-lld
>
> (ninja check-lldb doesn't complete for me with or without this patch.)
>
> https://reviews.llvm.org/D24996
>
> Files:
>   clang/lib/Analysis/FormatString.cpp
>   clang/lib/CodeGen/CodeGenModule.cpp
>   clang/lib/Format/Encoding.h
>   clang/lib/Frontend/TextDiagnostic.cpp
>   clang/lib/Lex/Lexer.cpp
>   clang/lib/Lex/LiteralSupport.cpp
>   clang/lib/Sema/SemaChecking.cpp
>   clang/lib/Sema/SemaExpr.cpp
>   lldb/source/DataFormatters/StringPrinter.cpp
>   lldb/source/Plugins/Process/minidump/MinidumpTypes.cpp
>   llvm/include/llvm/Support/ConvertUTF.h
>   llvm/lib/Support/CMakeLists.txt
>   llvm/lib/Support/ConvertUTF.c
>   llvm/lib/Support/ConvertUTF.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160929/998b22ed/attachment.html>


More information about the llvm-commits mailing list