<div dir="ltr">Phab is down, but I looked at the diff and it lgtm. Feel free to commit.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 27, 2016 at 6:07 PM, Justin Lebar <span dir="ltr"><<a href="mailto:jlebar@google.com" target="_blank">jlebar@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">jlebar created this revision.<br>
jlebar added a reviewer: rnk.<br>
jlebar added a subscriber: llvm-commits.<br>
Herald added subscribers: mgorny, beanz, klimek.<br>
<br>
This lets people link against LLVM and their own version of the UTF<br>
library.<br>
<br>
I determined this only affects llvm, clang, lld, and lldb by running<br>
<br>
$ git grep -wl 'UTF[0-9]\+\|\bConvertUTF\<wbr>bisLegalUTF\|getNumBytesFor' | cut -f 1 -d '/' | sort | uniq<br>
  clang<br>
  lld<br>
  lldb<br>
  llvm<br>
<br>
Tested with<br>
<br>
  ninja lldb<br>
  ninja check-clang check-llvm check-lld<br>
<br>
(ninja check-lldb doesn't complete for me with or without this patch.)<br>
<br>
<a href="https://reviews.llvm.org/D24996" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D24996</a><br>
<br>
Files:<br>
  clang/lib/Analysis/<wbr>FormatString.cpp<br>
  clang/lib/CodeGen/<wbr>CodeGenModule.cpp<br>
  clang/lib/Format/Encoding.h<br>
  clang/lib/Frontend/<wbr>TextDiagnostic.cpp<br>
  clang/lib/Lex/Lexer.cpp<br>
  clang/lib/Lex/LiteralSupport.<wbr>cpp<br>
  clang/lib/Sema/SemaChecking.<wbr>cpp<br>
  clang/lib/Sema/SemaExpr.cpp<br>
  lldb/source/DataFormatters/<wbr>StringPrinter.cpp<br>
  lldb/source/Plugins/Process/<wbr>minidump/MinidumpTypes.cpp<br>
  llvm/include/llvm/Support/<wbr>ConvertUTF.h<br>
  llvm/lib/Support/CMakeLists.<wbr>txt<br>
  llvm/lib/Support/ConvertUTF.c<br>
  llvm/lib/Support/ConvertUTF.<wbr>cpp<br>
<br>
</blockquote></div><br></div>