[PATCH] D24940: [thinlto] Add cold-callsite import heuristic
    Mehdi AMINI via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Sep 27 17:07:27 PDT 2016
    
    
  
mehdi_amini added inline comments.
================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:296
@@ +295,3 @@
+      BonusMultiplier = ImportHotMultiplier;
+    else if (Edge.second.Hotness == CalleeInfo::HotnessType::Cold)
+      BonusMultiplier = ImportColdMultiplier;
----------------
Oh I see why you did it. Maybe a static function close to the cl::opt?
`const float BonusMultiplier = getBonusMultiplierForHotness(Edge.second.Hotness);`
(Straw man naming)
https://reviews.llvm.org/D24940
    
    
More information about the llvm-commits
mailing list