[PATCH] D24587: Output optimization remarks in YAML

[Hal Finkel via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D24587#553118, @anemet wrote:

> In https://reviews.llvm.org/D24587#553073, @hfinkel wrote:
>
> > Using ore:: seems safer. That's a good option. I don't like std::make_pair, it is pretty long, and implies something about the implementation we might later wish to change.
>
>
> Great.  Do you want to see the namespace as part of this patch or is OK as a follow-on?




In https://reviews.llvm.org/D24587#553118, @anemet wrote:

> In https://reviews.llvm.org/D24587#553073, @hfinkel wrote:
>
> > Using ore:: seems safer. That's a good option. I don't like std::make_pair, it is pretty long, and implies something about the implementation we might later wish to change.
>
>
> Great.  Do you want to see the namespace as part of this patch or is OK as a follow-on?


This patch (i.e. it should be committed that way if that's what we intend to use), but otherwise, this LGTM.


https://reviews.llvm.org/D24587