[PATCH] D24587: Output optimization remarks in YAML

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 14:51:41 PDT 2016


anemet added a comment.

In https://reviews.llvm.org/D24587#553073, @hfinkel wrote:

> Using ore:: seems safer. That's a good option. I don't like std::make_pair, it is pretty long, and implies something about the implementation we might later wish to change.


Great.  Do you want to see the namespace as part of this patch or is OK as a follow-on?


https://reviews.llvm.org/D24587





More information about the llvm-commits mailing list