[PATCH] D23680: [ThinLTO] Emit files for distributed builds for all modules

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:755
@@ -754,1 +754,3 @@
 
+// Write empty files that may be expected by a distributed build
+// system when invoked with thinlto_index_only. This is invoked when
----------------
pcc wrote:
> > But it also prevents error checking that we did in fact run the thin link and get outputs.
> You could do that by reading the LinkedObjectsFile, no?
> 
> But okay, I suppose this is fine since it doesn't preclude a better implementation on the bazel side later.
> You could do that by reading the LinkedObjectsFile, no?

That's difficult since where the outputs are checked is low level generic job management functionality, and not cognizant of the fact that this is ThinLTO (I looked at this initially).

> But okay, I suppose this is fine since it doesn't preclude a better implementation on the bazel side later.

Ok thanks.


https://reviews.llvm.org/D23680