[PATCH] D23680: [ThinLTO] Emit files for distributed builds for all modules

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 21 12:11:52 PDT 2016


pcc added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:755
@@ -754,1 +754,3 @@
 
+// Write empty files that may be expected by a distributed build
+// system when invoked with thinlto_index_only. This is invoked when
----------------
> But it also prevents error checking that we did in fact run the thin link and get outputs.
You could do that by reading the LinkedObjectsFile, no?

But okay, I suppose this is fine since it doesn't preclude a better implementation on the bazel side later.


https://reviews.llvm.org/D23680





More information about the llvm-commits mailing list