[PATCH] D24687: [llvm-cov] Add a project coverage summary above the index page.

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 14:03:18 PDT 2016


vsk added a comment.

> If the project is branched, the longest-common prefix of the path (I called the project directory) will show the branch name. The project directory will tell the user where the source code come from.


It would be easier for me to understand the motivation behind this if you could upload an example report with your changes. I still don't understand what it is about the current scheme that makes it difficult for readers to figure out where some source file comes from.


================
Comment at: tools/llvm-cov/SourceCoverageViewHTML.cpp:431
@@ -390,1 +430,3 @@
+  OSRef << BeginCenteredDiv << BeginTable;
+  emitColumnLabelsForIndex(OSRef);
   for (unsigned I = 0, E = FileReports.size(); I < E; ++I)
----------------
This patch still seems larger than it needs to be. Can't we get the entire desired functional change by just inserting another `emitFileSummary(OSRef, "Totals", Totals, /*IsTotals=*/true)` here?


https://reviews.llvm.org/D24687





More information about the llvm-commits mailing list