[PATCH] D24687: [llvm-cov] Add a project coverage summary above the index page.

[Ying Yi via llvm-commits]

Hi Vedant,


I have attached the index.html page which includes the project directory in
the summary, and separate columns for files and directories in the index
table. Listing the project directory in summary allows user to construct
the full file path.


For example:

Project directory: I:\svn\PS4\toolchain-test\tests\branches\PS4_4.500\benchmarks

File directory: \Bullet-2.76\Demos\Benchmarks

 The file BenchmarkDemo.cpp could find in the folder:
 I:\svn\PS4\toolchain-test\tests\branches\PS4_4.500\benchmarks\Bullet-2.76\Demos\Benchmarks
.

Thanks,


On Tue, Sep 20, 2016 at 10:03 PM, Vedant Kumar <vsk at apple.com> wrote:

> vsk added a comment.
>
> > If the project is branched, the longest-common prefix of the path (I
> called the project directory) will show the branch name. The project
> directory will tell the user where the source code come from.
>
>
> It would be easier for me to understand the motivation behind this if you
> could upload an example report with your changes. I still don't understand
> what it is about the current scheme that makes it difficult for readers to
> figure out where some source file comes from.
>
>
> ================
> Comment at: tools/llvm-cov/SourceCoverageViewHTML.cpp:431
> @@ -390,1 +430,3 @@
> +  OSRef << BeginCenteredDiv << BeginTable;
> +  emitColumnLabelsForIndex(OSRef);
>    for (unsigned I = 0, E = FileReports.size(); I < E; ++I)
> ----------------
> This patch still seems larger than it needs to be. Can't we get the entire
> desired functional change by just inserting another `emitFileSummary(OSRef,
> "Totals", Totals, /*IsTotals=*/true)` here?
>
>
> https://reviews.llvm.org/D24687
>
>
>
>


-- 
Ying Yi
SN Systems - Sony Interactive Entertainment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160921/af01b6a2/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: html_index.zip
Type: application/zip
Size: 9006 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160921/af01b6a2/attachment.zip>