[lld] r281754 - Recommit r281721 "[ELF] - Linkerscript: implement EXCLUDE_FILE in the middle of a input section description."

[George Rimar via llvm-commits]

>>Can you add a comment saying that list is used to avoid a compiler (libc++?) bug? std::vector is far more common, so it is nice to justify why a list is used.

>>
>>
>>Thanks,
>>Rafael
>

?>Rui already changed that place in r281803, to use struct instead of pair,

>but seems also had problems with vector (see r281805), as comment now says:

>

>  // We use std::list instead of std::vector because SectionPattern
>  // do not support move assignment.
>
>I am not sure it is correct comment though, as I think struct without anything like desctructors,
>and just that has 2 movable fields should be movable.
>
>There is no link on buildbot in commit message for 281805,
>I`ll check if swiching to struct helped my FreeBSD VM where It was reproducible.

??>

>George.

And I just tried and issue does not reproduce for me on r281803 which uses struct
instead of std::pair. So I am not sure. Is std::list is really needed after that, Rui ?

George.?




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160919/a51e682f/attachment.html>