<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p><span style="font-size: 12pt; color: rgb(33, 33, 33);">>></span><span style="font-size: 12pt; color: rgb(33, 33, 33);">Can you add a comment saying that list is used to avoid a compiler (libc++?) bug? std::vector is far more common, so it is nice to justify
why a list is used.</span><br>
</p>
<div dir="ltr" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif">
<div>
<div style="color:rgb(33,33,33)">
<div>
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>>> </div>
<div>>> </div>
<div>>>Thanks,</div>
<div>>>Rafael</div>
<div>> </div>
<div>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">>Rui already changed that place in r<span style="font-size:12pt">281803, to use struct instead of pair,</span></p>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><span style="font-size:12pt">>but seems also had problems with vector (see <span style="background-color:rgb(255,255,255)"></span><span style="font-size:12pt; background-color:rgb(255,255,255)">r<span style="font-size:12pt">281805</span>)</span>,
as comment now says:</span></p>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><span style="font-size:12pt">>
</span></p>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">> // We use std::list instead of std::vector because SectionPattern</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">> // do not support move assignment.<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">> </div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">>I am not sure it is correct comment though, as I think struct without anything like desctructors,<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">>and just that has 2 movable fields should be movable.<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">> </div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">>There is no link on buildbot in commit message for 281805, </div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">>I`ll check if swiching to struct helped my FreeBSD VM where It was reproducible.<br>
</div>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">><br>
</p>
<p style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">>George.<br>
</p>
<br>
</div>
<div>And I just tried and issue does not reproduce for me on r<span style="font-size: 12pt;">281803 which uses struct</span></div>
<div><span style="font-size: 12pt;"></span><span style="font-size: 12pt;">instead of std::pair. So I am not sure. Is std::list is really needed after that, Rui ?</span></div>
<div><span style="font-size: 12pt;"><br>
</span></div>
<div><span style="font-size: 12pt;">George.</span>
<div><br>
<br>
</div>
<br>
</div>
<div> </div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>