[PATCH] D24645: AMDGPU: Don't use offen if it is 0

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 17 07:23:10 PDT 2016


nhaehnle added a comment.

The computation of NewOffset should be shared between the load and store paths.

I guess changing the MachineInstr could also be shared using MachineInstr::RemoveOperand, but the resulting code might not be much cleaner.

The rest looks good to me.


https://reviews.llvm.org/D24645





More information about the llvm-commits mailing list