[PATCH] D24645: AMDGPU: Don't use offen if it is 0

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 17 08:37:15 PDT 2016


arsenm added a comment.

In https://reviews.llvm.org/D24645#545602, @nhaehnle wrote:

> The computation of NewOffset should be shared between the load and store paths.
>
> I guess changing the MachineInstr could also be shared using MachineInstr::RemoveOperand, but the resulting code might not be much cleaner.
>
> The rest looks good to me.


Ma original plan was to just re-use buildScratchLoadStore which is what https://reviews.llvm.org/D24630 was for, but that changes from scavenging a VGPR to an SGPR and I wasn't sure what the consequences of that might be


https://reviews.llvm.org/D24645





More information about the llvm-commits mailing list