[PATCH] D24604: [ELF] - Implemented --sort-section cmd line option and SORT_NONE script command.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:970-972
@@ -969,3 +969,5 @@
     return SortByAlignment;
+  if (skip("SORT_NONE"))
+    return SortDisabled;
   return SortNone;
 }
----------------
This naming scheme is confusing. SORT_NONE is mapped to SortDisabled, and SortNone doesn't mean SORT_NONE?

================
Comment at: ELF/LinkerScript.cpp:1032
@@ -996,2 +1031,3 @@
     expect(")");
+    applySortKind(Cmd);
     return Cmd;
----------------
We are reading something here, but you are applying? This function name doesn't feel right.


https://reviews.llvm.org/D24604