[PATCH] D24294: [ELF] - Implemented --section-start, -Ttext, -Tdata, -Tbss options.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 06:09:50 PDT 2016


grimar added inline comments.

================
Comment at: ELF/Driver.cpp:403-405
@@ +402,5 @@
+  if (auto *Arg = Args.getLastArg(OPT_Tdata))
+    Ret[".data"] = parseSectionAddress(Arg->getValue(), Arg);
+  if (auto *Arg = Args.getLastArg(OPT_Tbss))
+    Ret[".bss"] = parseSectionAddress(Arg->getValue(), Arg);
+  return Ret;
----------------
I find what clang-format do is ugly sometimes. And what it did for previous revision of this was ugly, but I was unable to change that. That is what I meant.


https://reviews.llvm.org/D24294





More information about the llvm-commits mailing list