[PATCH] D24294: [ELF] - Implemented --section-start, -Ttext, -Tdata, -Tbss options.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Driver.cpp:387
@@ +386,3 @@
+  if (S.getAsInteger(16, VA))
+    error(Err);
+  return VA;
----------------
ruiu wrote:
> do
> 
>   error("invalid argument: " + stringize(Arg));
I did not know about stringnize(). Thank you for hint.

================
Comment at: ELF/Driver.cpp:403-405
@@ +402,5 @@
+  if (auto *Arg = Args.getLastArg(OPT_Ttext))
+    Ret[".text"] = parseSectionAddress(Arg->getValue(),
+                                       Twine("invalid argument for -Ttext: ") +
+                                           Arg->getValue());
+  if (auto *Arg = Args.getLastArg(OPT_Tdata))
----------------
ruiu wrote:
> This doesn't look very beautiful.
Fixed. What personally I do not like here is a way how clang-format works.
In modern time I do not like to see code formatted to the 1/3 of my screen width at left. That is how the result looks for me now though.


https://reviews.llvm.org/D24294