[PATCH] D24162: [yaml] Add the ability to pass in context at the map level

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 10:03:27 PDT 2016


zturner added a comment.

I moved the structs out of the yaml namespace as you suggested.  Tested on VS 2013 and everything works fine.  I'll upload a new patch if you want, but the only change was simply moving the classes in the unit tests to the global namespace.

And yes, I agree with you it uses some confusing design patterns.  I can try to explain it in more detail if you like, let me know if that would be helpful.


https://reviews.llvm.org/D24162





More information about the llvm-commits mailing list