[llvm] r280918 - Revert "[ARM] Lower UDIV+UREM to UDIV+MLS (and the same for SREM)"

Pablo Barrio via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 08:01:53 PDT 2016


Thank you Renato. I will have a look at the failing tests first. I will chase you on IRC when I get my feet wet if that's fine.


Cheers,

Pablo

________________________________
From: Renato Golin <renato.golin at linaro.org>
Sent: 08 September 2016 13:15:50
To: Pablo Barrio
Cc: LLVM Commits
Subject: Re: [llvm] r280918 - Revert "[ARM] Lower UDIV+UREM to UDIV+MLS (and the same for SREM)"

On 8 September 2016 at 11:05, Pablo Barrio via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: pabbar01
> Date: Thu Sep  8 05:05:57 2016
> New Revision: 280918
>
> URL: http://llvm.org/viewvc/llvm-project?rev=280918&view=rev
> Log:
> Revert "[ARM] Lower UDIV+UREM to UDIV+MLS (and the same for SREM)"
>
> This reverts commit r280808.
>
> It is possible that this change results in an infinite loop. This
> is causing timeouts in some tests on ARM, and a Chromebook bot is
> failing.

Hi Pablo,

It is possible, but I was not able to get to the bottom of this, as my
Chromebook was crashing even before that patch. Though, I had an
"experiment" with my Chromebook, so I wasn't very sure and started
looking around it... :)

If the test-suite passes, this could also fix both self-hosting bots,
too. I also may have an idea why this is happening (validation loop).
Ping me later, if you want to discuss this, but essentially, just
testing on the test-suite shall point you in the right direction.

cheers,
--renato

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160908/d8b7747c/attachment.html>


More information about the llvm-commits mailing list