[llvm] r280918 - Revert "[ARM] Lower UDIV+UREM to UDIV+MLS (and the same for SREM)"

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 05:15:50 PDT 2016


On 8 September 2016 at 11:05, Pablo Barrio via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: pabbar01
> Date: Thu Sep  8 05:05:57 2016
> New Revision: 280918
>
> URL: http://llvm.org/viewvc/llvm-project?rev=280918&view=rev
> Log:
> Revert "[ARM] Lower UDIV+UREM to UDIV+MLS (and the same for SREM)"
>
> This reverts commit r280808.
>
> It is possible that this change results in an infinite loop. This
> is causing timeouts in some tests on ARM, and a Chromebook bot is
> failing.

Hi Pablo,

It is possible, but I was not able to get to the bottom of this, as my
Chromebook was crashing even before that patch. Though, I had an
"experiment" with my Chromebook, so I wasn't very sure and started
looking around it... :)

If the test-suite passes, this could also fix both self-hosting bots,
too. I also may have an idea why this is happening (validation loop).
Ping me later, if you want to discuss this, but essentially, just
testing on the test-suite shall point you in the right direction.

cheers,
--renato


More information about the llvm-commits mailing list