[PATCH] D22112: Disambiguate a constant with both 0B prefix and H suffix.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 07:57:26 PDT 2016

rnk added a comment.

Pretty close

Comment at: lib/MC/MCParser/AsmLexer.cpp:274
@@ +273,3 @@
+    if (*CurPtr == 'h' || *CurPtr == 'H') {
+      // hexadecimal number
These 'if' blocks should select the base, and then you can factor out the bodies, which are the same except for being in base16 and base2 and having a different diagnostic.


More information about the llvm-commits mailing list