[PATCH] D23931: [XRay] ARM 32-bit no-Thumb support in LLVM

[Serge Rogatch via llvm-commits]

rSerge marked 6 inline comments as done.

================
Comment at: lib/Target/X86/X86AsmPrinter.h:74-94
@@ -73,23 +73,2 @@
 
-  // This describes the kind of sled we're storing in the XRay table.
-  enum class SledKind : uint8_t {
-    FUNCTION_ENTER = 0,
-    FUNCTION_EXIT = 1,
-    TAIL_CALL = 2,
-  };
-
-  // The table will contain these structs that point to the sled, the function
-  // containing the sled, and what kind of sled (and whether they should always
-  // be instrumented).
-  struct XRayFunctionEntry {
-    const MCSymbol *Sled;
-    const MCSymbol *Function;
-    SledKind Kind;
-    bool AlwaysInstrument;
-    const class Function *Fn;
-  };
-
-  // All the sleds to be emitted.
-  std::vector<XRayFunctionEntry> Sleds;
-
   // All instructions emitted by the X86AsmPrinter should use this helper
----------------
Do you mean the description for the diff? Or a comment in the source code?

================
Comment at: test/CodeGen/ARM/xray-attribute-instrumentation.ll:5
@@ +4,3 @@
+; CHECK-LABEL: Lxray_sled_0:
+; CHECK-NEXT:  .ascii "\005\000\000\352"
+; CHECK-NEXT:  .ascii  "\000\360 \343"
----------------
rengolin wrote:
> I was expecting Nops...
The first instruction is a jump over the NOPs. The other 6 instructions are NOPs.


https://reviews.llvm.org/D23931