[PATCH] D24102: [LLVM/Support] - Disallow match() method of llvm::Regex to change object state.
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 1 05:06:12 PDT 2016
Maybe just add the warn_unused_result attribute?
On August 31, 2016 6:59:33 PM EDT, David Blaikie <dblaikie at gmail.com> wrote:
>dblaikie added a comment.
>I'm not as comfortable with this change - have you looked around to see
>if any callers are actually checking the error after calling Match?
>It seems like a client could have a problem in either case (if Regex
>says "no match" when it's really "ran out of memory" then maybe the
>code would behave incorrectly - assuming a match wasn't present when it
>may actually have been present).
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits