[PATCH] D24102: [LLVM/Support] - Disallow match() method of llvm::Regex to change object state.
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 31 15:59:33 PDT 2016
dblaikie added a comment.
I'm not as comfortable with this change - have you looked around to see if any callers are actually checking the error after calling Match?
It seems like a client could have a problem in either case (if Regex says "no match" when it's really "ran out of memory" then maybe the code would behave incorrectly - assuming a match wasn't present when it may actually have been present).
More information about the llvm-commits