[PATCH] D23897: [SelectionDAG] Generate vector_shuffle nodes for undersized result vector sizes

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 14:54:16 PDT 2016

mkuper added inline comments.

Comment at: lib/Target/X86/X86ISelLowering.cpp:26349
@@ +26348,3 @@
+  // We only care about shuffles of 128/256-bit vectors of i32/i64.
+  if (!VT.is128BitVector() && !VT.is256BitVector())
RKSimon wrote:
> You need an early out for !isa<ShuffleVectorSDNode>(N) as I think we can get here from target shuffle nodes as well as shufflevector nodes.
Right, thanks!


More information about the llvm-commits mailing list