[PATCH] D22779: Clone block with icmp+branch if it likely results in further jump threading

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 18:55:11 PDT 2016

reames added a subscriber: reames.

Comment at: lib/Transforms/Scalar/JumpThreading.cpp:885
@@ -884,1 +884,3 @@
+  // If this is an otherwise-unthreadable conditional branch on a compare,
+  // duplicate this into its predecessor if that will result in the value of the
This comments needs clarified.  I was going to do a quick drive by style review, but after reading this three times, I'm not clear what you're trying to do.  That's a pretty good sign the comment needs adjusted. :)

I think you've mainly got a grammar problem; this reads as one long run on sentence which is hard to parse.  


More information about the llvm-commits mailing list