[PATCH] D23774: [ELF] - Remove VersionScriptParser class and move the members to ScriptParser

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM


================
Comment at: ELF/LinkerScript.cpp:1411
@@ +1410,3 @@
+// Parse the --version-script argument. We currently only accept the following
+// version script syntax:
+//
----------------
rafael wrote:
> The comment is out of date, no? We can probably delete it.
Yeah, it is I think out of date.

================
Comment at: ELF/LinkerScript.cpp:1415
@@ +1414,3 @@
+//
+void elf::parseVersionScript(MemoryBufferRef MB) {
+  ScriptParser(MB.getBuffer(), false).parseVersionScript();
----------------
parse -> read for the sake of consistency.


https://reviews.llvm.org/D23774