[PATCH] D23774: [ELF] - Remove VersionScriptParser class and move the members to ScriptParser

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 11:11:21 PDT 2016

rafael added a subscriber: rafael.
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.

Fine by me, but wait for a final OK from Rui.

Comment at: ELF/LinkerScript.cpp:593-596
@@ -592,5 +592,6 @@
   ScriptParser(StringRef S, bool B) : ScriptParserBase(S), IsUnderSysroot(B) {}
-  void run();
+  void parseLinkerScript();
+  void parseVersionScript();
Given the other names, maybe readLinkerScript and readVersionScript?

Comment at: ELF/LinkerScript.cpp:1411
@@ +1410,3 @@
+// Parse the --version-script argument. We currently only accept the following
+// version script syntax:
The comment is out of date, no? We can probably delete it.


More information about the llvm-commits mailing list