[PATCH] D23799: [ESan][MIPS] Adds support for MIPS64

[Derek Bruening via llvm-commits]

bruening added inline comments.

================
Comment at: lib/esan/esan.cpp:150
@@ +149,3 @@
+  // This is based on the assumption that the intial stack is always allocated
+  // in the topmost segment of the virtual address space and the assumption
+  // holds true on all the platforms currently supported.
----------------
slthakur wrote:
> bruening wrote:
> > nit: for x86-64 the vsyscall region is a higher address than the stack
> Okay. The vsyscall region is placed in the upper half of the canonical address space which is used by the kernel. So would it be correct to say that "the initial stack is always allocated
>  in the topmost segment of the user address space" ?
Works for me

================
Comment at: lib/esan/esan_shadow.h:136
@@ -135,3 @@
-// We'll want to use templatized functions over the ShadowMapping once
-// we support more platforms.
-#error Platform not supported
----------------
slthakur wrote:
> bruening wrote:
> > This was overlooked?
> The comment was preserved in the updated diff. I forgot to mark this as "done".
The comment as-is is not really relevant though b/c even more platforms beyond these 2 are unlikely to change the picture: adding the 2nd one here is what moved several constants to variables and that's what we might want to templatize away.


Repository:
  rL LLVM

https://reviews.llvm.org/D23799