[PATCH] D23799: [ESan][MIPS] Adds support for MIPS64
Sagar Thakur via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 29 02:16:44 PDT 2016
slthakur marked 3 inline comments as done.
Comment at: lib/esan/esan.cpp:150
@@ +149,3 @@
+ // This is based on the assumption that the intial stack is always allocated
+ // in the topmost segment of the virtual address space and the assumption
+ // holds true on all the platforms currently supported.
> nit: for x86-64 the vsyscall region is a higher address than the stack
Okay. The vsyscall region is placed in the upper half of the canonical address space which is used by the kernel. So would it be correct to say that "the initial stack is always allocated
in the topmost segment of the user address space" ?
Comment at: lib/esan/esan_shadow.h:136
@@ -135,3 @@
-// We'll want to use templatized functions over the ShadowMapping once
-// we support more platforms.
-#error Platform not supported
> This was overlooked?
The comment was preserved in the updated diff. I forgot to mark this as "done".
More information about the llvm-commits