[PATCH] D23415: [Inliner] Report when inlining fails because callee's def is unavailable

[Adam Nemet via llvm-commits]

anemet added inline comments.

================
Comment at: include/llvm/Analysis/OptimizationDiagnosticInfo.h:98
@@ -97,1 +97,3 @@
+                                    const Value *V, const Twine &Msg,
+                                    bool Verbose = false);
 
----------------
davidxl wrote:
> Perhaps change Verbose to IsVerbose or IsMsgVerbose
> 
> // If IsVerbose is true, the message is considered verbose and will only be emitted when verbose output is turned on 
IsVerbose WFM, thanks!

================
Comment at: test/Transforms/Inline/optimization-remarks.ll:2
@@ +1,3 @@
+; RUN: opt < %s -inline -pass-remarks=inline -pass-remarks-missed=inline \
+; RUN:       -pass-remarks-analysis=inline -S 2>&1 | \
+; RUN:       FileCheck -check-prefix=CHECK -check-prefix=NO_HOTNESS %s
----------------
davidxl wrote:
> bad formatting?
Why?  I just wrapped the long line.

I usually do it like this: multiple RUN lines, separated with \, continuation lines indented.


https://reviews.llvm.org/D23415