[PATCH] D23415: [Inliner] Report when inlining fails because callee's def is unavailable

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: include/llvm/Analysis/OptimizationDiagnosticInfo.h:98
@@ -97,1 +97,3 @@
+                                    const Value *V, const Twine &Msg,
+                                    bool Verbose = false);
 
----------------
Perhaps change Verbose to IsVerbose or IsMsgVerbose

// If IsVerbose is true, the message is considered verbose and will only be emitted when verbose output is turned on 

================
Comment at: lib/Transforms/IPO/Inliner.cpp:455
@@ +454,3 @@
+          if (Callee->isDeclaration()) {
+            ORE.emitOptimizationRemarkMissedAndAnalysis(
+                DEBUG_TYPE, &I,
----------------
verbose output is fine as long as there are ways for tools to do post-processing to filter/order messages according to importance.  This is future work of course.

================
Comment at: test/Transforms/Inline/optimization-remarks.ll:2
@@ +1,3 @@
+; RUN: opt < %s -inline -pass-remarks=inline -pass-remarks-missed=inline \
+; RUN:       -pass-remarks-analysis=inline -S 2>&1 | \
+; RUN:       FileCheck -check-prefix=CHECK -check-prefix=NO_HOTNESS %s
----------------
bad formatting?


https://reviews.llvm.org/D23415