[PATCH] D23315: [ELF] - Let linkerscript to use own outputsections factory.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 11 01:55:02 PDT 2016


The spec says:

"In the first phase, input sections that match in name, type and
attribute flags should be concatenated into single sections ..."

So I guess we want to follow that general rule ?

LS looks to be different story.?


Best regards,
George.
________________________________
??: Rui Ueyama <ruiu at google.com>
??????????: 11 ??????? 2016 ?. 4:26
????: reviews+D23315+public+dda6b6fb97bf1dba at reviews.llvm.org
?????: George Rimar; Rafael Ávila de Espíndola; Ed Maste; evgeny777; Davide Italiano; llvm-commits
????: Re: [PATCH] D23315: [ELF] - Let linkerscript to use own outputsections factory.

On Wed, Aug 10, 2016 at 12:29 AM, George Rimar <grimar at accesssoftek.com<mailto:grimar at accesssoftek.com>> wrote:
grimar added a comment.

In https://reviews.llvm.org/D23315#510206, @ruiu wrote:

> Is there any problem if we group sections just by name?


Do you mean group into one output section by name ? That is exactly what this patch do.
For linkerscript's OutputSectionFactory "key" is simple StringRef which is output section name.
And I combine the flags when add more sections.

I meant to say that why don't you do this even in Writer.cpp.



https://reviews.llvm.org/D23315




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160811/38666116/attachment.html>


More information about the llvm-commits mailing list