<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p></p>
<p style="margin-right: 0px; margin-bottom: 12px; margin-left: 0px; padding: 0px; border: 0px; line-height: 18.85px; background-color: rgb(255, 255, 255);">
<span style="background-color: rgb(255, 255, 255);"></span>The spec says:<span style="font-family: "Segoe UI", "Segoe UI Web Regular", "Segoe UI Symbol", "Helvetica Neue", Helvetica, Arial, sans-serif; font-size: 13px;"><br>
</span></p>
<p style="margin-right: 0px; margin-bottom: 12px; margin-left: 0px; padding: 0px; border: 0px; font-family: "Segoe UI", "Segoe UI Web Regular", "Segoe UI Symbol", "Helvetica Neue", Helvetica, Arial, sans-serif; font-size: 13px; line-height: 18.85px; background-color: rgb(255, 255, 255);">
"In the first phase, input sections that match in name, type and<br>
attribute flags should be concatenated into single sections ..."<br>
</p>
<p>So I guess we want to follow that general rule ?<br>
</p>
<p>LS looks to be different story.<br>
</p>
<p><br>
</p>
<div id="Signature">
<div class="BodyFragment"><font size="2">
<div class="PlainText">Best regards,<br>
George.</div>
</font></div>
</div>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>От:</b> Rui Ueyama <ruiu@google.com><br>
<b>Отправлено:</b> 11 августа 2016 г. 4:26<br>
<b>Кому:</b> reviews+D23315+public+dda6b6fb97bf1dba@reviews.llvm.org<br>
<b>Копия:</b> George Rimar; Rafael Ávila de Espíndola; Ed Maste; evgeny777; Davide Italiano; llvm-commits<br>
<b>Тема:</b> Re: [PATCH] D23315: [ELF] - Let linkerscript to use own outputsections factory.</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Wed, Aug 10, 2016 at 12:29 AM, George Rimar <span dir="ltr">
<<a href="mailto:grimar@accesssoftek.com" target="_blank">grimar@accesssoftek.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
grimar added a comment.<br>
<span><br>
In <a href="https://reviews.llvm.org/D23315#510206" rel="noreferrer" target="_blank">
https://reviews.llvm.org/D2331<wbr>5#510206</a>, @ruiu wrote:<br>
<br>
> Is there any problem if we group sections just by name?<br>
<br>
<br>
</span>Do you mean group into one output section by name ? That is exactly what this patch do.<br>
For linkerscript's OutputSectionFactory "key" is simple StringRef which is output section name.<br>
And I combine the flags when add more sections.<br>
</blockquote>
<div><br>
</div>
<div>I meant to say that why don't you do this even in Writer.cpp.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<br>
<br>
<a href="https://reviews.llvm.org/D23315" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2331<wbr>5</a><br>
<br>
<br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>