[PATCH] D23227: [IndVarSimplify] Integrate changes in D18777 and D18867 which depend on each other

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 11:21:45 PDT 2016


sanjoy added a comment.

Hi Li,

In https://reviews.llvm.org/D23227#507506, @lihuang wrote:

> Hi Sanjoy,
>
> I have merged the changes in https://reviews.llvm.org/D18777 and https://reviews.llvm.org/D18867 because they depend on each other and should go in together, and have rebased the change on top of latest source. Do you think this whole thing is ready to go in?


Why do they depend on each other?  If they individually are correct and pass all tests (and only need the other one to be fully effective) then they should go in separately.

- Sanjoy


https://reviews.llvm.org/D23227





More information about the llvm-commits mailing list