[PATCH] D23227: [IndVarSimplify] Integrate changes in D18777 and D18867 which depend on each other

Li Huang via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 13:10:47 PDT 2016


lihuang added a comment.

Hi Sanjoy,

Actually I was wrong here, the change in IndVarSimplify depends on that of ValueTracking but not the opposite.

The change in IndVarSimplify uses ValueTracking's isKnownNonNegative to test the signedness of IV and IV users, so without the change in ValueTracking the iv-widen tests will fail. I thought the tests I made for ValueTracking changes also requires IndVars change but they actually don't.

Sorry about this, just ignore this patch.

-Li Huang


https://reviews.llvm.org/D23227





More information about the llvm-commits mailing list