[llvm] r277982 - [PM] More workaround for PR28400

[Mehdi Amini via llvm-commits]

> On Aug 7, 2016, at 11:43 PM, Chandler Carruth via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> On Sun, Aug 7, 2016 at 10:46 PM Sean Silva via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Author: silvas
> Date: Mon Aug  8 00:38:06 2016
> New Revision: 277982
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=277982&view=rev <http://llvm.org/viewvc/llvm-project?rev=277982&view=rev>
> Log:
> [PM] More workaround for PR28400
> 
> See my replies on the other threads.
> 
> This does not seem to be a reasonable thing to land without review, and if it is it really needs a better change description than this.

FWIW I felt the same seeing this commits when it came through.

I assume it is done for good reasons, but the commit title isn’t clear by itself and the PR linked is quite broad. There is not comment in the code to figure out either so one may only guess.
(especially since it mentions this being a “workaround”, I’d expect it to be clear in the code as a comment or something)

— 
Mehdi



>  
> 
> Modified:
>     llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp
>     llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp
>     llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp
> 
> Modified: llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp?rev=277982&r1=277981&r2=277982&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp?rev=277982&r1=277981&r2=277982&view=diff>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp Mon Aug  8 00:38:06 2016
> @@ -434,6 +434,7 @@ AlignmentFromAssumptionsPass::run(Functi
>    ScalarEvolution &SE = AM.getResult<ScalarEvolutionAnalysis>(F);
>    DominatorTree &DT = AM.getResult<DominatorTreeAnalysis>(F);
>    bool Changed = runImpl(F, AC, &SE, &DT);
> +  AM.invalidate<ScalarEvolutionAnalysis>(F);
>    if (!Changed)
>      return PreservedAnalyses::all();
>    PreservedAnalyses PA;
> 
> Modified: llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp?rev=277982&r1=277981&r2=277982&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp?rev=277982&r1=277981&r2=277982&view=diff>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp Mon Aug  8 00:38:06 2016
> @@ -157,6 +157,7 @@ PreservedAnalyses NaryReassociatePass::r
>    auto *TTI = &AM.getResult<TargetIRAnalysis>(F);
> 
>    bool Changed = runImpl(F, AC, DT, SE, TLI, TTI);
> +  AM.invalidate<ScalarEvolutionAnalysis>(F);
>    if (!Changed)
>      return PreservedAnalyses::all();
> 
> 
> Modified: llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp?rev=277982&r1=277981&r2=277982&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp?rev=277982&r1=277981&r2=277982&view=diff>
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp (original)
> +++ llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp Mon Aug  8 00:38:06 2016
> @@ -869,6 +869,8 @@ PreservedAnalyses LoopSimplifyPass::run(
>    for (LoopInfo::iterator I = LI->begin(), E = LI->end(); I != E; ++I)
>      Changed |= simplifyLoop(*I, DT, LI, SE, AC, true /* PreserveLCSSA */);
> 
> +  AM.invalidate<ScalarEvolutionAnalysis>(F);
> +
>    if (!Changed)
>      return PreservedAnalyses::all();
>    PreservedAnalyses PA;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160807/c7d5e3d3/attachment.html>