<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 7, 2016, at 11:43 PM, Chandler Carruth via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote"><div dir="ltr" class="">On Sun, Aug 7, 2016 at 10:46 PM Sean Silva via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Author: silvas<br class="">Date: Mon Aug 8 00:38:06 2016<br class="">New Revision: 277982<br class=""><br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=277982&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=277982&view=rev</a><br class="">Log:<br class="">[PM] More workaround for PR28400<br class=""></blockquote><div class=""><br class=""></div><div class="">See my replies on the other threads.</div><div class=""><br class=""></div><div class="">This does not seem to be a reasonable thing to land without review, and if it is it really needs a better change description than this.</div></div></div></div></blockquote><div><br class=""></div><div>FWIW I felt the same seeing this commits when it came through.</div><div><br class=""></div><div>I assume it is done for good reasons, but the commit title isn’t clear by itself and the PR linked is quite broad. There is not comment in the code to figure out either so one may only guess.</div><div>(especially since it mentions this being a “workaround”, I’d expect it to be clear in the code as a comment or something)</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote"><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><br class="">Modified:<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp<br class=""><br class="">Modified: llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp<br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp?rev=277982&r1=277981&r2=277982&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp (original)<br class="">+++ llvm/trunk/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp Mon Aug 8 00:38:06 2016<br class="">@@ -434,6 +434,7 @@ AlignmentFromAssumptionsPass::run(Functi<br class=""> ScalarEvolution &SE = AM.getResult<ScalarEvolutionAnalysis>(F);<br class=""> DominatorTree &DT = AM.getResult<DominatorTreeAnalysis>(F);<br class=""> bool Changed = runImpl(F, AC, &SE, &DT);<br class="">+ AM.invalidate<ScalarEvolutionAnalysis>(F);<br class=""> if (!Changed)<br class=""> return PreservedAnalyses::all();<br class=""> PreservedAnalyses PA;<br class=""><br class="">Modified: llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp<br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp?rev=277982&r1=277981&r2=277982&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp (original)<br class="">+++ llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp Mon Aug 8 00:38:06 2016<br class="">@@ -157,6 +157,7 @@ PreservedAnalyses NaryReassociatePass::r<br class=""> auto *TTI = &AM.getResult<TargetIRAnalysis>(F);<br class=""><br class=""> bool Changed = runImpl(F, AC, DT, SE, TLI, TTI);<br class="">+ AM.invalidate<ScalarEvolutionAnalysis>(F);<br class=""> if (!Changed)<br class=""> return PreservedAnalyses::all();<br class=""><br class=""><br class="">Modified: llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp<br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp?rev=277982&r1=277981&r2=277982&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp?rev=277982&r1=277981&r2=277982&view=diff</a><br class="">==============================================================================<br class="">--- llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp (original)<br class="">+++ llvm/trunk/lib/Transforms/Utils/LoopSimplify.cpp Mon Aug 8 00:38:06 2016<br class="">@@ -869,6 +869,8 @@ PreservedAnalyses LoopSimplifyPass::run(<br class=""> for (LoopInfo::iterator I = LI->begin(), E = LI->end(); I != E; ++I)<br class=""> Changed |= simplifyLoop(*I, DT, LI, SE, AC, true /* PreserveLCSSA */);<br class=""><br class="">+ AM.invalidate<ScalarEvolutionAnalysis>(F);<br class="">+<br class=""> if (!Changed)<br class=""> return PreservedAnalyses::all();<br class=""> PreservedAnalyses PA;<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class=""></blockquote></div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">llvm-commits mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="mailto:llvm-commits@lists.llvm.org" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">llvm-commits@lists.llvm.org</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></div></blockquote></div><br class=""></body></html>