[PATCH] D23015: [ThinLTO/gold] Conservatively handle unknown GVs when internalizing

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D23015#502735, @twoh wrote:

> @tejohnson The test code surely generates GV with ".%d" appended, but it doesn't trigger the assertion failure even without this patch, both for r274523 and r277147. Let me try again with more recent version.


Hmm, it does for me and I am at r277267. If I put the assert back it fails with that assert.

> My original failure cannot be reproduced by the recent version(r277147) because other issue hides the original failure.


Is this the -g failure? Can you try without -g?

> However, once I apply this patch to r274523 then it works (linking fails with another error but it definitely makes more progress). I'm just concerning the test code may target wrong.





https://reviews.llvm.org/D23015