[PATCH] D23015: [ThinLTO/gold] Conservatively handle unknown GVs when internalizing

Taewook Oh via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 1 15:55:55 PDT 2016


twoh added a comment.

@tejohnson The test code surely generates GV with ".%d" appended, but it doesn't trigger the assertion failure even without this patch, both for r274523 and r277147. Let me try again with more recent version.

My original failure cannot be reproduced by the recent version(r277147) because other issue hides the original failure. However, once I apply this patch to r274523 then it works (linking fails with another error but it definitely makes more progress). I'm just concerning the test code may target wrong.


https://reviews.llvm.org/D23015





More information about the llvm-commits mailing list