[PATCH] D22974: pdbdump: Dump Free Page Map contents.

[Rui Ueyama via llvm-commits]

On Fri, Jul 29, 2016 at 2:32 PM, Zachary Turner <zturner at google.com> wrote:

> zturner added a comment.
>
> In `MsfBuilder::build()`, can you set the value of `FreePageMap` before
> returning?
>

We can, but I'd like to do it in the next patch. This patch is focusing on
printing rather than creating FPM.


>
>
> ================
> Comment at: lib/DebugInfo/PDB/Raw/PDBFile.cpp:52
> @@ -51,3 +51,3 @@
>  }
>
>  uint32_t PDBFile::getNumDirectoryBytes() const {
> ----------------
> ruiu wrote:
> > How?
> All we really want is a simple memset though.  The function is already
> there `init_words()`, it's just private.
>

We could change that, but should be done in a separate patch.


>
>
> https://reviews.llvm.org/D22974
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160729/9911d5d6/attachment.html>