[PATCH] D22974: pdbdump: Dump Free Page Map contents.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 29 14:32:55 PDT 2016


zturner added a comment.

In `MsfBuilder::build()`, can you set the value of `FreePageMap` before returning?


================
Comment at: lib/DebugInfo/PDB/Raw/PDBFile.cpp:52
@@ -51,3 +51,3 @@
 }
 
 uint32_t PDBFile::getNumDirectoryBytes() const {
----------------
ruiu wrote:
> How?
All we really want is a simple memset though.  The function is already there `init_words()`, it's just private.  


https://reviews.llvm.org/D22974





More information about the llvm-commits mailing list