[PATCH] D22740: Move Dot variable from LinkerScript to ScriptConfig.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a subscriber: rafael.
rafael added a comment.

I am not sure how complex linker scripts expression will get, so it is hard to have an opinion on this.

In general when interpreting an expression, the interpretation is made in an Environment, which maps names to values. It would be another way of doing this, but tt is not clear if that generality is needed for linker scripts. Is Dot the only variable that can have different values in different contexts?


================
Comment at: ELF/LinkerScript.h:27
@@ -26,3 +26,1 @@
 
-typedef std::function<uint64_t(uint64_t)> Expr;
-
----------------
grimar wrote:
> I would really leave Expr type, that was nice and clear to have.
Agreed.


https://reviews.llvm.org/D22740