[PATCH] D22740: Move Dot variable from LinkerScript to ScriptConfig.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 05:39:35 PDT 2016


grimar added a comment.

In https://reviews.llvm.org/D22740#494857, @ruiu wrote:

> I don't think this patch changes the behavior at all. It just moves a variable from one class to another. So I don't think there's no concern on semantics.


It does not change, and IMO does not help. It is just neutral.
What I meant that I just think we will probably want some different solution for Dot generally. 
Since there is no big difference I am not against landing this if you feel it is better.


================
Comment at: ELF/LinkerScript.h:27
@@ -26,3 +26,1 @@
 
-typedef std::function<uint64_t(uint64_t)> Expr;
-
----------------
I would really leave Expr type, that was nice and clear to have.


https://reviews.llvm.org/D22740





More information about the llvm-commits mailing list