[PATCH] D22795: [LinkerScript] Support EXCLUDE_FILE inside KEEP

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 27 00:16:48 PDT 2016


grimar added inline comments.

================
Comment at: lld/trunk/test/ELF/linkerscript/linkerscript-excludefile.s:8
@@ +7,3 @@
+
+# RUN: echo "SECTIONS {} " > %t.script
+# RUN: ld.lld -o %t --script %t.script %t1 %t2 %t3.notinclude
----------------
excessive space at the end

================
Comment at: lld/trunk/test/ELF/linkerscript/linkerscript-excludefile.s:14
@@ +13,3 @@
+# CHECK: Disassembly of section .text:
+# CHECK: _start:
+# CHECK:      120:       48 c7 c0 3c 00 00 00    movq    $60, %rax
----------------
I think you want to use CHECK-NEXT here.

================
Comment at: lld/trunk/test/ELF/linkerscript/linkerscript-excludefile.s:32
@@ +31,3 @@
+
+# EXCLUDE: Disassembly of section .patatino:
+# EXCLUDE: _start:
----------------
Ditto.


Repository:
  rL LLVM

https://reviews.llvm.org/D22795





More information about the llvm-commits mailing list