[PATCH] D22742: [WIP] Fix `-jobs=<N>` where <N> > 1 on macOS.

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 19:07:53 PDT 2016


kcc added a comment.

> > I am not happy with this implementation as it seems like a gross

> 


Gross indeed. 
At the very least, move all the OSX-specific code to an OSX-specific file.

Also, if you had to write that much code, surely it deserves a test :)

> > This allows pressing CTRL+C in the terminal to do the right thing on macOS.

> 


What exactly do you mean by the "right thing"? 
Do we need to do that "right thing" at the cost of such extra complexity?


https://reviews.llvm.org/D22742





More information about the llvm-commits mailing list