[PATCH] D21612: [compiler-rt] [XRay] Basic initialization and flag definition for XRay runtime

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 05:02:23 PDT 2016


rSerge requested changes to this revision.
This revision now requires changes to proceed.

================
Comment at: compiler-rt/trunk/lib/xray/xray_interface.cc:126
@@ +125,3 @@
+        // FIXME: Print out an error here.
+        continue;
+      }
----------------
mprotect() leaks due to this (so that the executable code block stays modifiable).

================
Comment at: compiler-rt/trunk/lib/xray/xray_interface.cc:162
@@ +161,3 @@
+        // FIXME: Print out an error here.
+        continue;
+      }
----------------
mprotect() leaks due to this (so that the executable code block stays modifiable).


Repository:
  rL LLVM

https://reviews.llvm.org/D21612





More information about the llvm-commits mailing list