[PATCH] D21612: [compiler-rt] [XRay] Basic initialization and flag definition for XRay runtime

Serge Rogatch via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 25 04:57:55 PDT 2016


rSerge reopened this revision.
rSerge added a comment.
This revision is now accepted and ready to land.

It looks like there are 2 places where the second mprotect (returning the executable code block permissions to no-modify) can leak in compiler-rt/trunk/lib/xray/xray_interface.cc . Consider using RAII idiom. See my comments inline.


Repository:
  rL LLVM

https://reviews.llvm.org/D21612





More information about the llvm-commits mailing list