[PATCH] D22617: [ELF] - Linkerscript: add InputSectionDescription command to LS parser.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:220
@@ -211,4 +219,3 @@
 bool LinkerScript<ELFT>::shouldKeep(InputSectionBase<ELFT> *S) {
-  for (StringRef Pat : Opt.KeptSections)
-    if (globMatch(Pat, S->getSectionName()))
-      return true;
+  for (const std::unique_ptr<BaseCommand> &Base : Opt.Commands)
+    if (auto *OutSec = dyn_cast<OutputSectionCommand>(Base.get()))
----------------
evgeny777 wrote:
> It looks like a slow-down compared with previous one, no?
That fits in new design. I am sure we will spend time on optimization of LS later,
when will be able to run benchmarks. And probably many places will need tweaking,
for now I don't think it is critical to change until major slowdown is proven.



https://reviews.llvm.org/D22617